Closures are recursively reachable #125996

tmiasko · 2024-06-04T21:08:14Z

rustbot · 2024-06-04T21:08:21Z

rustbot has assigned @pnkfelix.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

oli-obk · 2024-06-04T22:00:42Z

@bors r+

bors · 2024-06-04T22:00:45Z

📌 Commit 5d26f58 has been approved by oli-obk

It is now in the queue for this repository.

…ble, r=oli-obk Closures are recursively reachable

Rollup of 7 pull requests Successful merges: - rust-lang#125273 (bootstrap: implement new feature `bootstrap-self-test`) - rust-lang#125800 (Fix `mut` static task queue in SGX target) - rust-lang#125903 (rustc_span: Inline some hot functions) - rust-lang#125920 (Allow static mut definitions with #[linkage]) - rust-lang#125921 (coverage: Carve out hole spans in a separate early pass) - rust-lang#125995 (Use inline const blocks to create arrays of `MaybeUninit`.) - rust-lang#125996 (Closures are recursively reachable) r? `@ghost` `@rustbot` modify labels: rollup

compiler-errors · 2024-06-05T01:12:06Z

compiler/rustc_passes/src/reachable.rs

@@ -157,6 +157,7 @@ impl<'tcx> ReachableContext<'tcx> {
                }
                hir::ImplItemKind::Type(_) => false,
            },
+            Node::Expr(&hir::Expr { kind: hir::ExprKind::Closure(..), .. }) => true,


Why isn't this:

Suggested change

Node::Expr(&hir::Expr { kind: hir::ExprKind::Closure(..), .. }) => true,

Node::Expr(&hir::Expr { kind: hir::ExprKind::Closure(hir::Closure { def_id, .. }), .. }) => recursively_reachable(def_id),

?

Closures are always recursively reachable, so a call to recursively_reachable would be redundant.

compiler-errors · 2024-06-05T01:12:55Z

Also is there a bug report or anything about this issue? Seems strange to have such little information attached to this PR 😅

tmiasko · 2024-06-05T06:00:03Z

The issue is from #122505 (comment). Opened a dedicated issue for tracking purposes #126012.

…kingjubilee Rollup of 12 pull requests Successful merges: - rust-lang#123168 (Add `size_of` and `size_of_val` and `align_of` and `align_of_val` to the prelude) - rust-lang#125273 (bootstrap: implement new feature `bootstrap-self-test`) - rust-lang#125683 (Rewrite `suspicious-library`, `resolve-rename` and `incr-prev-body-beyond-eof` `run-make` tests in `rmake.rs` format) - rust-lang#125815 (`rustc_parse` top-level cleanups) - rust-lang#125903 (rustc_span: Inline some hot functions) - rust-lang#125906 (Remove a bunch of redundant args from `report_method_error`) - rust-lang#125920 (Allow static mut definitions with #[linkage]) - rust-lang#125982 (Make deleting on LinkedList aware of the allocator) - rust-lang#125995 (Use inline const blocks to create arrays of `MaybeUninit`.) - rust-lang#125996 (Closures are recursively reachable) - rust-lang#126003 (Add a co-maintainer for the two ARMv4T targets) - rust-lang#126004 (Add another test for hidden types capturing lifetimes that outlive but arent mentioned in substs) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#125996 - tmiasko:closure-recursively-reachable, r=oli-obk Closures are recursively reachable Fixes rust-lang#126012.

apiraino · 2024-06-13T09:32:41Z

Sorry this backport was accepted last week (Zulip) but I missed to mark it as such.

@rustbot label +beta-accepted

cuviper · 2024-06-14T01:08:27Z

It's too late for 1.79.0, but this could be stable-nominated if needed.

@rustbot label -beta-nominated -beta-accepted

apiraino · 2024-06-14T08:55:37Z

ok, then I'll stable nominate since there's another PR candidate for a stable backport (if a dot release will be considered)

@rustbot +stable-nominated

apiraino · 2024-06-20T14:39:34Z

Stable backport accpeted as per compiler team on Zulip, if a point release is planned.

A backport PR will be authored by the release team at the end of the current development cycle.

@rustbot label +stable-accepted

cuviper · 2024-08-01T16:45:05Z

Clearing stable backport labels since we didn't ship a 1.79 point release, and this is already in current stable 1.80.0.

@rustbot label -stable-nominated -stable-accepted

Closures are recursively reachable

5d26f58

rustbot assigned pnkfelix Jun 4, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 4, 2024

tmiasko assigned oli-obk and unassigned pnkfelix Jun 4, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 4, 2024

oli-obk added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 4, 2024

fmease added a commit to fmease/rust that referenced this pull request Jun 4, 2024

Rollup merge of rust-lang#125996 - tmiasko:closure-recursively-reacha…

a82d14b

…ble, r=oli-obk Closures are recursively reachable

fmease mentioned this pull request Jun 4, 2024

Rollup of 7 pull requests #126002

Closed

compiler-errors reviewed Jun 5, 2024

View reviewed changes

workingjubilee mentioned this pull request Jun 5, 2024

Rollup of 12 pull requests #126016

Merged

bors merged commit eb2819e into rust-lang:master Jun 5, 2024
6 checks passed

rustbot added this to the 1.80.0 milestone Jun 5, 2024

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jun 5, 2024

Unrolled build for rust-lang#125996

7d73072

Rollup merge of rust-lang#125996 - tmiasko:closure-recursively-reachable, r=oli-obk Closures are recursively reachable Fixes rust-lang#126012.

tmiasko deleted the closure-recursively-reachable branch June 5, 2024 14:32

rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jun 13, 2024

rustbot removed beta-nominated Nominated for backporting to the compiler in the beta channel. beta-accepted Accepted for backporting to the compiler in the beta channel. labels Jun 14, 2024

apiraino added the stable-nominated Nominated for backporting to the compiler in the stable channel. label Jun 14, 2024

rustbot added the stable-accepted Accepted for backporting to the compiler in the stable channel. label Jun 20, 2024

rustbot removed stable-nominated Nominated for backporting to the compiler in the stable channel. stable-accepted Accepted for backporting to the compiler in the stable channel. labels Aug 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Closures are recursively reachable #125996

Closures are recursively reachable #125996

tmiasko commented Jun 4, 2024 •

edited

Loading

rustbot commented Jun 4, 2024

oli-obk commented Jun 4, 2024

bors commented Jun 4, 2024

compiler-errors Jun 5, 2024

tmiasko Jun 5, 2024

compiler-errors commented Jun 5, 2024

tmiasko commented Jun 5, 2024 •

edited

Loading

apiraino commented Jun 13, 2024

cuviper commented Jun 14, 2024

apiraino commented Jun 14, 2024 •

edited

Loading

apiraino commented Jun 20, 2024

cuviper commented Aug 1, 2024

	Node::Expr(&hir::Expr { kind: hir::ExprKind::Closure(..), .. }) => true,
	Node::Expr(&hir::Expr { kind: hir::ExprKind::Closure(hir::Closure { def_id, .. }), .. }) => recursively_reachable(def_id),

Closures are recursively reachable #125996

Closures are recursively reachable #125996

Conversation

tmiasko commented Jun 4, 2024 • edited Loading

rustbot commented Jun 4, 2024

oli-obk commented Jun 4, 2024

bors commented Jun 4, 2024

compiler-errors Jun 5, 2024

Choose a reason for hiding this comment

tmiasko Jun 5, 2024

Choose a reason for hiding this comment

compiler-errors commented Jun 5, 2024

tmiasko commented Jun 5, 2024 • edited Loading

apiraino commented Jun 13, 2024

cuviper commented Jun 14, 2024

apiraino commented Jun 14, 2024 • edited Loading

apiraino commented Jun 20, 2024

cuviper commented Aug 1, 2024

tmiasko commented Jun 4, 2024 •

edited

Loading

tmiasko commented Jun 5, 2024 •

edited

Loading

apiraino commented Jun 14, 2024 •

edited

Loading